DroidKaigi / conference-app-2017

The Official Conference App for DroidKaigi 2017 Tokyo
Apache License 2.0
470 stars 140 forks source link

"Welcome talk talk" is shown in Toolbar #336

Closed YusukeIwaki closed 7 years ago

YusukeIwaki commented 7 years ago

Overview (Required)

Toolbar shows thw word "talk" twice unexpectedly, during collapsing.

I don't know if this bug is caused by the bug of support libs or by some kind of implementation :sweat_smile:

Actually this bug is really trivial, and no need to fix soon. However it would be better for us to share the issue and the workaround (if it exists). :)

Screenshot

konifar commented 7 years ago

:eyes:

konifar commented 7 years ago

Thanks for report! Actually we use multiline-collapsingtoolbar which extends support lib CollapsingToolbar to show multiline text.

This seems the library's spec, not bug 🤔 But I guess black text is wrong.

hironytic commented 7 years ago

I think this issue is related.

We can avoid this problem by simply deleting the shadow in SessionDetailExpandedToolbarTitle style, but the appearance becomes worse. :worried:

konifar commented 7 years ago

@hironytic Thanks! I guess it might be better to remove shadow and put black alpha color on the background image 💭