add reviewdog configuration - Githubissues

DroidKaigi / conference-app-2017

The Official Conference App for DroidKaigi 2017 Tokyo

Apache License 2.0

470 stars 140 forks source link

add reviewdog configuration #339

Closed yshrsmz closed 7 years ago

yshrsmz commented 7 years ago

Issue

266

Overview (Required)

Introducing reviewdog, lint notifier.
As stated in #266, you need a GitHub personal access token to use reviewdog.
With this setup, reviewdog will swallow all stdout lint result. If you want to check actual result on CircleCI's build page, I'm going update PR to use xml output instead.

Links

Screenshot

Before	After

konifar commented 7 years ago

:eyes:

konifar commented 7 years ago

Thanks! Will do it!

As stated in #266, you need to a GitHub personal access token to use reviewdog.

konifar commented 7 years ago

Sorry to be late 🙇 I'll do this tonight 💪

yshrsmz commented 7 years ago

never mind. I know you have lots of things to do :)

konifar commented 7 years ago

Sorry to be late 🙇 I'll do it this weekend!

yshrsmz commented 7 years ago

FYI: comments from reviewdog will look like this https://github.com/yshrsmz/monotweety/pull/88

almost same setup :) https://github.com/yshrsmz/monotweety/blob/master/circle.yml#L26

konifar commented 7 years ago

I set Env variable on Circle CI. Thanks! Let me merge this 👍