search

DroidKaigi / conference-app-2017

The Official Conference App for DroidKaigi 2017 Tokyo
Apache License 2.0
470 stars 140 forks source link

Start splash more quickly #341

Closed ogapants closed 7 years ago

ogapants commented 7 years ago

Issue

none

Overview (Required)

A white screen is displayed until the inflation of Splash layout is completed. "background" attribute of the theme can solve this problem. I created a splash-like drawable with xml, but it's not perfect. 😢 Please close this PR if you feel unnecessary 🙇

Links

none

Screenshot

Before After
konifar commented 7 years ago

:eyes:

konifar commented 7 years ago

Thanks for improvement! According to your gif, looks good!

ogapants commented 7 years ago

Thank you for reviewing late at night 🙇

konifar commented 7 years ago

Don't worry 😉 I'm just working now.

konifar commented 7 years ago

LGTM! 💯 Thanks.