search

DroidKaigi / conference-app-2017

The Official Conference App for DroidKaigi 2017 Tokyo
Apache License 2.0
470 stars 140 forks source link

Add page finishing function when over scrolled to SessionDetailActivity #359

Closed chibatching closed 7 years ago

chibatching commented 7 years ago

Issue

Overview (Required)

Links

Screenshot

Before After
konifar commented 7 years ago

Cool 🆒

konifar commented 7 years ago

Interesting implementation 👀 I thought it's better to make custom activity, but your custom CoordinatorLayout also looks good and reasonable. Let me taste this on my device after CI success 👍

konifar commented 7 years ago

Sorry to be late review 🙇 I checked on my device. It's really awesome! Thank you so much 👍 LGTM! 💯

chibatching commented 7 years ago

Thank you for your review!! 😄

jmatsu commented 7 years ago

Oops, I didn't notice this PR was merged 😇 Sorry, please ignore my reviews.

chibatching commented 7 years ago

I'd like to make another PR to fix your comment! 👍

konifar commented 7 years ago

@jmatsu Thanks for great review 😄 @chibatching Appreciate you. Looking forward to next PR 👍