Add tests for ContributorsRepository and data sources

DroidKaigi / conference-app-2017

The Official Conference App for DroidKaigi 2017 Tokyo

Apache License 2.0

470 stars 140 forks source link

Add tests for ContributorsRepository and data sources #362

Closed k-kagurazaka closed 7 years ago

k-kagurazaka commented 7 years ago

Issue

None

Overview (Required)

Add more tests to ContributorsRepositoryTest
Add ContributorsLocalDataSourceTest and ContributorsRemoteDataSourceTest

k-kagurazaka commented 7 years ago

Hmm... Test failed by NEP in SessionsRepositoryTest#findAllLocalCache. I didn't change SessionsRepositoryTest in this PR and all tests are passed in my local environment. Do you have knowledge of this behavior ❓

k-kagurazaka commented 7 years ago

I found my misunderstanding. Failed test is ContributorsRemoteDataSourceTest#findAll but it's passed in my env 😭

konifar commented 7 years ago

Thanks!! Sorry, I'm out now. I'll review later :bowing_man:

k-kagurazaka commented 7 years ago

Oh... I miss merge. Please wait for cleaning and force push 😱

konifar commented 7 years ago

NP! It's okay. Take your time 😉

k-kagurazaka commented 7 years ago

Please pass CI 🙏

konifar commented 7 years ago

🙏 🙏 🙏

k-kagurazaka commented 7 years ago

😱

konifar commented 7 years ago

😭

k-kagurazaka commented 7 years ago

CI of my forked repository succeeded. https://circleci.com/gh/k-kagurazaka/conference-app-2017/8

I don't know what's the difference between this repo and my repo 😭 Could you kick rebuild the CI? 🙇 If it fails, I close this PR because this does not contain production code (only test code).

konifar commented 7 years ago

👏

konifar commented 7 years ago

Thanks! Let me merge 😄