DroidKaigi / conference-app-2017

The Official Conference App for DroidKaigi 2017 Tokyo
Apache License 2.0
470 stars 140 forks source link

Fix session detail UP button #369

Closed kobakei closed 7 years ago

kobakei commented 7 years ago

Issue

Overview (Required)

Links

Screenshot

Before After
kobakei commented 7 years ago

I have fixed to pass parent integer but I see this error in CircleCI >< This error may be caused by other reasons, does someone know this issue?

io.github.droidkaigi.confsched2017.repository.sessions.SessionsRepositoryTest > findAllLocalCache STANDARD_ERROR
    WARNING: unknown service shortcut
    java.lang.NullPointerException
        at com.github.gfx.android.orma.BuiltInSerializers.serializeDate(BuiltInSerializers.java:88)
        at io.github.droidkaigi.confsched2017.model.Session_Relation.upsertWithoutTransaction(Session_Relation.java:50)
        at io.github.droidkaigi.confsched2017.model.Session_Relation.upsertWithoutTransaction(Session_Relation.java:13)
        at com.github.gfx.android.orma.Relation$5.run(Relation.java:320)
        at com.github.gfx.android.orma.OrmaConnection.transactionSync(OrmaConnection.java:369)
        at com.github.gfx.android.orma.Relation.upsert(Relation.java:317)
        at io.github.droidkaigi.confsched2017.repository.sessions.SessionsLocalDataSource.updateAllSync(SessionsLocalDataSource.java:66)
        at io.github.droidkaigi.confsched2017.repository.sessions.SessionsLocalDataSource.lambda$updateAllAsync$0(SessionsLocalDataSource.java:72)
        at com.github.gfx.android.orma.OrmaConnection.transactionSync(OrmaConnection.java:369)
        at io.github.droidkaigi.confsched2017.model.OrmaDatabase.transactionSync(OrmaDatabase.java:79)
        at io.github.droidkaigi.confsched2017.model.OrmaDatabase$1.run(OrmaDatabase.java:90)
        at io.reactivex.internal.operators.completable.CompletableFromRunnable.subscribeActual(CompletableFromRunnable.java:35)
        at io.reactivex.Completable.subscribe(Completable.java:1631)
        at io.reactivex.internal.operators.completable.CompletableSubscribeOn$SubscribeOnObserver.run(CompletableSubscribeOn.java:64)
        at io.reactivex.Scheduler$1.run(Scheduler.java:134)
        at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:59)
        at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:51)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)
    java.lang.NullPointerException
        at com.github.gfx.android.orma.BuiltInSerializers.serializeDate(BuiltInSerializers.java:88)
        at io.github.droidkaigi.confsched2017.model.Session_Relation.upsertWithoutTransaction(Session_Relation.java:50)
        at io.github.droidkaigi.confsched2017.model.Session_Relation.upsertWithoutTransaction(Session_Relation.java:13)
        at com.github.gfx.android.orma.Relation$5.run(Relation.java:320)
        at com.github.gfx.android.orma.OrmaConnection.transactionSync(OrmaConnection.java:369)
        at com.github.gfx.android.orma.Relation.upsert(Relation.java:317)
        at io.github.droidkaigi.confsched2017.repository.sessions.SessionsLocalDataSource.updateAllSync(SessionsLocalDataSource.java:66)
        at io.github.droidkaigi.confsched2017.repository.sessions.SessionsLocalDataSource.lambda$updateAllAsync$0(SessionsLocalDataSource.java:72)
        at com.github.gfx.android.orma.OrmaConnection.transactionSync(OrmaConnection.java:369)
        at io.github.droidkaigi.confsched2017.model.OrmaDatabase.transactionSync(OrmaDatabase.java:79)
        at io.github.droidkaigi.confsched2017.model.OrmaDatabase$1.run(OrmaDatabase.java:90)
        at io.reactivex.internal.operators.completable.CompletableFromRunnable.subscribeActual(CompletableFromRunnable.java:35)
        at io.reactivex.Completable.subscribe(Completable.java:1631)
        at io.reactivex.internal.operators.completable.CompletableSubscribeOn$SubscribeOnObserver.run(CompletableSubscribeOn.java:64)
        at io.reactivex.Scheduler$1.run(Scheduler.java:134)
        at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:59)
        at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:51)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)
k-kagurazaka commented 7 years ago

The reason of CircleCI failure is fixed by #389 . I'm sorry for adding unstable test 🙇

kobakei commented 7 years ago

@k-kagurazaka Thanks!

@konifar If you have a time, would you merge or review this PR?

konifar commented 7 years ago

Sure!

konifar commented 7 years ago

@kobakei ping just in case 🏓

kobakei commented 7 years ago

@konifar Sorry for late response! I have fixed your review points. Please check it 👳

kobakei commented 7 years ago

@konifar Fixed! How about it?

konifar commented 7 years ago

LGTM!