Change for statement.

[kitwtnb]

Issue

• https://github.com/DroidKaigi/conference-app-2017/pull/366

Overview (Required)

• Because create new instance every time.

Links

• none

Thank for @eneim ! I learned a lot. 😇
Is this OK?

[konifar]

👀 @kitwtnb Awesome! Thanks for quick fix! LGTM @eneim Can you review?

[jmatsu]

What do you mean by every time?

for (Some some: createSomeList()) {
  ...
}

is equal to

for (Iterator iterator = createSomeList().iterator(); iterator.hasNext();) {
  Some some = (Some) myIterator.next();
  ...
}

The number of instance creations is same with the current one.

[eneim]

@konifar @kitwtnb sorry for the late reply, my exp is exactly as the following article: link to Medium. It was from 2015, but still a good practice to reference. Please take a look at the whole. I will try some profiling in current code base though.

[konifar]

@eneim Does this PR look good for you? 🤔

[eneim]

Ah sorry, @konifar @kitwtnb this looks good to me for the onDraw :D. FYI there are few steps to improve this class if you are really crazy about the performance. But don't spend too much time, I just want to mention a general practice :D.

[konifar]

Thanks! 👍