DroidKaigi / conference-app-2017

The Official Conference App for DroidKaigi 2017 Tokyo
Apache License 2.0
470 stars 140 forks source link

Translate messages when check/uncheck the session #371

Closed ogapants closed 7 years ago

ogapants commented 7 years ago

Issue

Overview (Required)

Links

Screenshot

konifar commented 7 years ago

LGTM! BTW, ใƒžใ‚คใƒชใ‚นใƒˆใซ่ฟฝๅŠ ใ™ใ‚‹ may be better because there is my sessions page now.

ogapants commented 7 years ago

Like this?

And shall I change English messages too? ๐Ÿค”

konifar commented 7 years ago

@ogapants Sorry to be late ๐Ÿ™‡ Yes, right. But I'm not sure... @ken5scal Can you help? ๐Ÿ‘ฐ

konifar commented 7 years ago

@ogapants If the reply comment will not come by 12:00 JST, can you change the message as you commented ๐Ÿ™‡ https://github.com/DroidKaigi/conference-app-2017/pull/371#issuecomment-281108602

ogapants commented 7 years ago

@konifar OK! BTW, why do you ask him...?

konifar commented 7 years ago

He is good at English ๐Ÿ˜ƒ

ogapants commented 7 years ago

Oh, I see ๐Ÿ˜†

ogapants commented 7 years ago

@konifar Sorry, I reconsidered about messages... ๐Ÿค” Currently, in most other cases, the word "check" is used instead of "add". So I think that it is good to remain "check". And as for Japanese, "ใƒใ‚งใƒƒใ‚ฏใ™ใ‚‹" may be better. What do you think about this?

konifar commented 7 years ago

Okay! Actually I don't have strong opinion about it and your suggestion makes sense for me. Let me merge! Sorry for long review and thanks a lot!

ogapants commented 7 years ago

Thank you for review ๐Ÿ™‡