DroidKaigi / conference-app-2017

The Official Conference App for DroidKaigi 2017 Tokyo
Apache License 2.0
470 stars 140 forks source link

[WIP] Implementation Questionnaire #397

Closed gen0083 closed 7 years ago

gen0083 commented 7 years ago

Issue

Overview (Required)

This is still on the way. We are working now.

Links

-

Screenshot

Before After
konifar commented 7 years ago

Thanks! Please tell me when I can review 👍

gen0083 commented 7 years ago

Now implement views for questionnaire page. I implement views type using on google form:

https://docs.google.com/forms/d/e/1FAIpQLSfAD2H_ePyLV3wqCEXwlxS9dGu3OKtr-IrxbGoLo4QYzJh_dw/viewform

You can check these views on QuestionnaireFragment. Selected value was bound to Questionnaire model in QuestionnaireViewModel. You can see what values are set when "Send Questionnaire" button clicked. (logged only to logcat)

Now I don't add all of questionnaire item because I have not implemented strings.xml yet. If you can review please advice me about view's implementation. Thanks.


日本語で補足

Webのアンケートフォームで使われている部品をViewとして作りました。 とりあえず作ったViewのすべてのタイプをQuestionnaireFragmentで試すことができます。 RadioButton with other fieldだけ挙動がまだおかしいです。 (その他のEditTextをタップするとクラッシュする)

Viewの実装方法、あとは変数名の付け方あたりを中心にレビューいただけると助かります。

konifar commented 7 years ago

Thanks! Let me merge first 🙇

gen0083 commented 7 years ago

Don't worry, please point out only the inevitable part if you find it 😄