Fix timezone issue - Githubissues

DroidKaigi / conference-app-2018

The Official Conference App for DroidKaigi 2018 Tokyo

Apache License 2.0

1.35k stars 332 forks source link

Fix timezone issue #434

Closed takahirom closed 6 years ago

takahirom commented 6 years ago

close #432

Overview (Required)

We should use JST all in the app. And only modify in showing.

takahirom commented 6 years ago

@nukka123 Can you review this?

nukka123 commented 6 years ago

@takahirom Ok, just a moment.

nukka123 commented 6 years ago

@takahirom I was preparing for the question. However, it seems that the answer has already been committed.

commited code is ok. but, I think there is one problem. When I operated it with my emulator, it seems that VIEW will not be updated when I return with Back key.

The problem has been corrected. As # 303, I think either of the following is necessary.

Take action to prompt update of VIEW
Add a message urging the application to be restarted on the setting screen.

takahirom commented 6 years ago

Yes! I create will create that issue!

konifar commented 6 years ago

LGTM!

nukka123 commented 6 years ago

LGTM😎