Add speakerId check. - Githubissues

DroidKaigi / conference-app-2018

The Official Conference App for DroidKaigi 2018 Tokyo

Apache License 2.0

1.35k stars 332 forks source link

Add speakerId check. #457

Closed murmurmuk closed 6 years ago

murmurmuk commented 6 years ago

Issue

close #449

Overview (Required)

Add speakId check to start speaker profile.

Screenshot

Before	After

takahirom commented 6 years ago

👀

konifar commented 6 years ago

👀

konifar commented 6 years ago

Thanks! Commented!

konifar commented 6 years ago

Thanks! It looks good. Actually I tried this but it's difficult than I expected...! I thought it's better to pass onSpeakerClickListener instead of speakerId, but it makes some boilerplate code.

Your fix looks good for now! Thank you so much! If you have any other good idea, feel free to send PR again! 🙏