Fix Firestore's offline get() problem - Githubissues

DroidKaigi / conference-app-2018

The Official Conference App for DroidKaigi 2018 Tokyo

Apache License 2.0

1.35k stars 332 forks source link

Fix Firestore's offline get() problem #483

Closed kakajika closed 6 years ago

kakajika commented 6 years ago

Issue

close #277

Overview (Required)

When device is offline and document doesn't exist, Firestore's get() cause error and return nothing. Instead, I changed code to use addSnapshotListener(...).
- FavoriteFirestoreDatabase::setupFavoritesDocument
- FavoriteFirestoreDatabase::favorite

Links

https://firebase.google.com/docs/firestore/manage-data/enable-offline#get_offline_data

takahirom commented 6 years ago

Looks good 👍 Thank you for your suggestion! We are so helped 🙇