search

DroidKaigi / conference-app-2018

The Official Conference App for DroidKaigi 2018 Tokyo
Apache License 2.0
1.35k stars 332 forks source link

Change to use vector drawable resource instead of PNG #513

Closed hkusu closed 6 years ago

hkusu commented 6 years ago

Overview (Required)

For the active icon on bottom navigation, change to use vector drawable resource instead of png.

konifar commented 6 years ago

:eyes:

hkusu commented 6 years ago

I also confirmed the display of vector drawable on pre-lollipop device.

_2018-01-28_22_43_06
konifar commented 6 years ago

Thanks! @takahirom Is it intentional to use png before?

takahirom commented 6 years ago

Probably your vector drawable is broken 🤔 If you can fix this , Please do it 🙏 Zeplin image Yours image

hkusu commented 6 years ago

OK, Please invite me to Zeplin project to get vector drawable resource. My Zeplin account is hkusu(kusu0806@gmail.com).

takahirom commented 6 years ago

@hkusu I invited! 👍

hkusu commented 6 years ago

Sorry, this icon can not be converted to a vector well.

2018-01-29 23 40 28

I think that it is good to remain in png format.

Please close the pull request if there is no problem 🙏

takahirom commented 6 years ago

Thank you for challenging