[#64] Shared element transition between speakers search and detail sc…

DroidKaigi / conference-app-2018

The Official Conference App for DroidKaigi 2018 Tokyo

Apache License 2.0

1.35k stars 332 forks source link

[#64] Shared element transition between speakers search and detail sc… #522

Closed mkano9 closed 6 years ago

mkano9 commented 6 years ago

…reens

Issue

close #64

Overview (Required)

-Added shared element transition on the speaker image view from Search Speaker screen to Speaker Detail screen. -The speaker image will transition with a curve and will run circular reveal animation on the yellow background at the top section.

mkano9 commented 6 years ago

Thanks for letting me work on this one. Please let me know what you think or what could be improved.

takahirom commented 6 years ago

🆒 matanmj32ftakahirom01292018120421

takahirom commented 6 years ago

Please fix crash when tapping speaker in session list 👍 matanmj32ftakahirom01292018120701

mkano9 commented 6 years ago

@takahirom @panpanini Thanks for looking at my PR! I updated my branch with your feedback.

mkano9 commented 6 years ago

@takahirom, I updated the branch with your suggestions. Thanks!

takahirom commented 6 years ago

LGTM 👍 Sorry. Please resolve conflict!

takahirom commented 6 years ago

Thank you for implementing cool animation! :cool:

mkano9 commented 6 years ago

@takahirom It was a pleasure! Thanks again for letting me work on this!