Fix and add instrumentation test

DroidKaigi / conference-app-2018

The Official Conference App for DroidKaigi 2018 Tokyo

Apache License 2.0

1.35k stars 332 forks source link

Fix and add instrumentation test #525

Closed gen0083 closed 6 years ago

gen0083 commented 6 years ago

Issue

I found error that using com.google.gms.tasks.Task<Void>.toSingle() and NPE occur. That code has not used in now. (Probably fixed with #509 ) But I think this test code is not wasted 😄

Overview (Required)

Add test code for FirebaseTaskExt
And fix exiting code caused by failed with wrong package name

I tested these test with ./gradlew :app:connectedDebugAndroidTest on my local machine and they were all green 👍

takahirom commented 6 years ago

Thanks 👍 LGTM 🙇 I want to introduce to CI 😭 But, It is probably very slow. I suffer.