Support offline mode for Sponsors

youta1119 commented 6 years ago

Issue

takahirom commented 6 years ago

Sorry, We should prepare release, I will see this pull request tomorrow 🙏

takahirom commented 6 years ago

Please fix lint errors 🙏

takahirom commented 6 years ago

This is a very hard work implementation, but I would like to change from three tables to one table. 🙇

You do not have to change the model class. I think that it is only necessary to have id, link, base64Img, imgUrl, groupIndex in that table.

I think that it is possible to smoothly implement the table conversion by mapper.

What do you think?

これはとてもhard workな実装になるのですが、3つのテーブルから1テーブルに変更したいです。

モデルクラスは変えなくていいです。私はそのテーブルにはid,link, base64Img, imgUrl,groupIndexがあるだけで良いと思います。

テーブルの変換はmapperで行えば多分スムーズに実装できる気がしています。

どう思いますか？

youta1119 commented 6 years ago

@takahirom I think that good. I'll try it

youta1119 commented 6 years ago

@takahirom I was deleteed SponsorGruopEntity and SponsorGroupWithSponsor. And I fixed SponsorEntity and mapper. Please review again:pray:

takahirom commented 6 years ago

takahirom commented 6 years ago

Sorry for taking long time 🙇

takahirom commented 6 years ago

We don't have the time Please let me merge selfly. Of course, your commit goes into master.