DroidKaigi / conference-app-2018

The Official Conference App for DroidKaigi 2018 Tokyo
Apache License 2.0
1.35k stars 332 forks source link

Handle FCM push on update news feed #550

Closed KeithYokoma closed 6 years ago

KeithYokoma commented 6 years ago

Overview (Required)

Changes

Screenshot

device-2018-02-01-133914

KeithYokoma commented 6 years ago

Additional Note:

  1. Push will not come until a feed is published.
  2. DroidKaigi app can receive and show notification even if it is in the background.
KeithYokoma commented 6 years ago

After this is merged, I will work on deploying firebase functions to prod env.

takahirom commented 6 years ago

Probably we should call createNotificationChannel for Android O 👀 You can use NotificationHelper. Please read it 🙏 https://github.com/droidkaigi/conference-app-2018/blob/6ccbfbb5a865968d4895037d8dd44839cab9e39c/app/src/main/java/io/github/droidkaigi/confsched2018/presentation/common/notification/NotificationHelper.kt#L17-L17

KeithYokoma commented 6 years ago

Got it!

takahirom commented 6 years ago

Thanks! Almost LGTM 👍

KeithYokoma commented 6 years ago

Resolving conflicts now!

takahirom commented 6 years ago

🙏

takahirom commented 6 years ago

LGTM 👍 🔔