DroidKaigi / conference-app-2018

The Official Conference App for DroidKaigi 2018 Tokyo
Apache License 2.0
1.35k stars 332 forks source link

fix issue #110 kotlin-dsl #561

Closed shikajiro closed 6 years ago

shikajiro commented 6 years ago

Issue

Overview (Required)

android{ compileSdkVersion(Versions.compileSdk) }

I made a kotlin file without using `ext`.
Because code completion can be used.

- Depends.kt file is management dependencies libraries.

ex:

object Depends { object Kotlin { val stdlib = "org.jetbrains.kotlin:kotlin-stdlib-jre7:${Versions.kotlin}" ...

implementation(Depends.Kotlin.stdlib)



- settings.gradle can not change to kts. It causes some compile error šŸ˜£

- I checked build & run. But I can not check deploy to Google Play.

## Links
- https://github.com/gradle/kotlin-dsl
### respect
- https://qiita.com/chibatching/items/d63c0c9afc8e1e6bc9de
- https://qiita.com/chibatching/items/3b40aea222b2a2f29d4b
- https://github.com/chibatching/KtsSample
- https://github.com/jaredsburrows/android-gif-example
- https://github.com/justjanne/QuasselDroid-ng

## Screenshot
no file
takahirom commented 6 years ago

šŸ†’

takahirom commented 6 years ago

LGTM šŸ‘ I want to try that šŸ˜„