search

DroidKaigi / conference-app-2018

The Official Conference App for DroidKaigi 2018 Tokyo
Apache License 2.0
1.35k stars 332 forks source link

Add share button to the Session Detail Screen #578

Closed rkowase closed 3 years ago

rkowase commented 6 years ago

Issue

Overview (Required)

Links

Screenshot

Before After
takahirom commented 6 years ago

I think two FABs are bad. Because FAB should be primary action. 👀 https://material.io/guidelines/components/buttons-floating-action-button.html

I think we should use menu icon. What do you think?

rkowase commented 6 years ago

I think two FABs are bad. Because FAB should be primary action. 👀 https://material.io/guidelines/components/buttons-floating-action-button.html I think we should use menu icon.

I agree. I'll use menu icon instead of FAB.

rkowase commented 6 years ago

I replaced.

Screenshot

Before After