Add PageMargin to ViewPager in SessionsFragment - Githubissues

DroidKaigi / conference-app-2018

The Official Conference App for DroidKaigi 2018 Tokyo

Apache License 2.0

1.35k stars 332 forks source link

Add PageMargin to ViewPager in SessionsFragment #594

Closed yt-tkhs closed 6 years ago

yt-tkhs commented 6 years ago

Issue

This PR has no issue 🙇

Overview (Required)

This is just suggestion. 🙌
Add page margin 16dp to ViewPager in SessionFragment.
I think each cards should be splitted, but there are sticking to cards in next page.

Details

This margin can be seen when only scrolling.
set Viewpager.pageMargin is not enough, and to achieve this correctly, we have to add android:clipChildren="false" to parents of CardView. (To show left and right shadow of CardView.)

Links

No links.

Screenshot

Before	After

takahirom commented 6 years ago

:cool:

takahirom commented 6 years ago

I learned a lot 👍 Thanks!