Closed kubode closed 6 years ago
🆒
This code is one of the places where I took the longest time to implement DroidKaigi 😓
I don't know about payload
Does current release have that support? 🤔 https://github.com/lisawray/groupie/blob/master/library/src/main/java/com/xwray/groupie/Section.java#L163
It probably 2.1.0-alpha1 😓
Please fix lint warnings 🙇
Fixed 😄
Probably you can use this format 👍 https://kotlinlang.org/docs/reference/coding-conventions.html#function-formatting
Can you fix to use normal expression 🙇
Expression functions should not wrap to two lines. If an expression function grows to require wrapping, use a normal function body, a return declaration, and normal expression wrapping rules instead.
https://android.github.io/kotlin-guides/style.html#expression-functions
In this case, lambda expression is declaring as default argument. So, I think it can't use normal expression.
Sorry I made mistake
I understood. Thanks you! I learned a lot by this pr!👍
Issue
Overview (Required)
HorizontalSessionsItem
's scroll position is not saved on favoritedRecyclerView.addOnScrollListener
to inline functionLinks
Screenshot
個人的なメモ