Fix like icon position(vertical position) on search page

DroidKaigi / conference-app-2018

The Official Conference App for DroidKaigi 2018 Tokyo

Apache License 2.0

1.35k stars 332 forks source link

Fix like icon position(vertical position) on search page #603

Open matsujun opened 6 years ago

matsujun commented 6 years ago

Overview (Required)

Sorry... my previous PR had one lack of consideration... If the session has 2 or 3 speakers, like icon moves up. It's better to place like icon at same place on every session card. So I changed to align it to most bottom speaker vertically in this PR.

// Each speaker icon size is 28dp. // it has 4dp margins // and speakers area has 16dp top/bottom mergines // 28 + 4 2 + 16 2 = 68dp

Screenshot

Before	After

matsujun commented 6 years ago

Ahhhh... This change looks not needed... Current (before this PR) "like" layout is same as normal (not search) session list. I close this PR.

takahirom commented 6 years ago

If you have time, I think it would be better to fix the session list together 👀