DroidKaigi / conference-app-2018

The Official Conference App for DroidKaigi 2018 Tokyo
Apache License 2.0
1.35k stars 332 forks source link

Save tab and scroll position which is shown before.(part 2) #605

Closed nacatl closed 6 years ago

nacatl commented 6 years ago

Issue

Overview (Required)

Links

Screenshot

save_tabs_and_scroll

nacatl commented 6 years ago

Sorry...I committed deferent user name... At first I clean up it.

takahirom commented 6 years ago

You can change user by changing Git email git config

git config ... git reset --hard 7ea51ff git checkout 0e0dbb5 . git commit -m "Separate parameter related previous session from Prefs" 3 more commits And you can force push git push -f origin save-last-session-scroll

nacatl commented 6 years ago

Thank you very much!!! I couldn't change before 2 commits, I try that commands!!!

jmatsu commented 6 years ago

Btw, I'd love to recommend the following way because this doesn't need hard reset. You can abort this processing by rebase --abort if you want.

git rebase -i 7ea51ff
# then, replace `pick` with `e`
git commit --amend --author="your_name <your_email>"
git rebase --continue
git commit --amend --author="your_name <your_email>"
git rebase --continue
git commit --amend --author="your_name <your_email>"
git rebase --continue
nacatl commented 6 years ago

I can say only "thank you"... 🙇

nacatl commented 6 years ago

Succeeded!! @takahirom @jmatsu Very thank you!!!

takahirom commented 6 years ago

LGTM 👍 Thank you for difficult challenge 💯

nacatl commented 6 years ago

Thank you for your reveiws and advices!!