Feature/#110 gradle kt - Githubissues

DroidKaigi / conference-app-2018

The Official Conference App for DroidKaigi 2018 Tokyo

Apache License 2.0

1.35k stars 332 forks source link

Closed shikajiro closed 6 years ago

shikajiro commented 6 years ago

I'm back.

Fixed reverted #561
bugfix proguard. changed setProguardFiles toproguardFiles. because deleted proguard-rules.pro settings. (thank you for @sckm )
update PlayPublisher setting. test is success!
checked release build for signingConfigs.create("release"). test is success!

takahirom commented 6 years ago

This probably conflict this PR The release is high priority. I talk with konifar https://github.com/DroidKaigi/conference-app-2018/pull/576

takahirom commented 6 years ago

Can you resolve conflict?

shikajiro commented 6 years ago

@takahirom resolved!

takahirom commented 6 years ago

Can I do this after my session in droidkaigi?(I don't have time to try this)

shikajiro commented 6 years ago

@takahirom no problem! It is OK after the meeting is over.

takahirom commented 6 years ago

@shikajiro Can you resolve conflict? 🙏

takahirom commented 6 years ago

👀

shikajiro commented 6 years ago

waiting for ci.

takahirom commented 6 years ago

Let's merge this 👍