DroidKaigi / conference-app-2018

The Official Conference App for DroidKaigi 2018 Tokyo
Apache License 2.0
1.35k stars 332 forks source link

Refactor set bundle(fragment argument) more like kotlin, with ktx #633

Closed gyamoto closed 6 years ago

gyamoto commented 6 years ago

Issue

Overview (Required)

Before After
Bundle().apply{ putString(KEY, value) } bundleOf(KEY to value)

Links

takahirom commented 6 years ago

🆒

gyamoto commented 6 years ago

😨 😐 🤔❓

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:testDebugUnitTest'.
> Process 'Gradle Test Executor 1' finished with non-zero exit value 137

* Try:
Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':app:testDebugUnitTest'.
...

https://circleci.com/gh/DroidKaigi/conference-app-2018/1312

takahirom commented 6 years ago

Probably It is out of memory. It fixed Can you resolve conflicts?

gyamoto commented 6 years ago

@takahirom thanks for fix OOM :pray: I will resolve conflict!

takahirom commented 6 years ago

I leaned! Thanks 👍 LGTM