Share RecycledViewPool between view pager content fragments

[chibatching]

Issue

• no issue

Overview (Required)

• Share RecyclerViewPool between content fragments of Sessions ViewPager
  • It will reduce RecyclerView item inflating count.
  • In my environment view inflate count is reduced to 31 from 95
  • Launch app(room mode - all tab) -> select right each room tab in tab order -> switch mode (Day2 14:00) -> select left each tab to all tab in tab order

Problem

I'm not sure it is appropriate to keep RecyclerViewPool on SessionsViewModel. I think there are three options.

1. Share through SessionsViewModel (This PR is) or other new ViewModel.
2. Keep pool on SessionFragment and each content Fragment get from it.
3. Keep pool on ViewPager and pass pool from ViewPager to content Fragment

Do you have any advice to give to?

Links

-

Screenshot

Before	After

[takahirom]

🆒

[takahirom]

We try this 👍

[takahirom]

@chibatching This is very useful pull request for all apps 👍 Sorry When merged I was high. I think this is leaking. Because ViewModel can exist across the recreation of Activity. And probably RecyclerViewPool have views that have activity SessionFragment or MainActivity should have that. Probably we should create an interface for that.

[chibatching]

You may be right. I''ll check and fix later! Thanks!

[takahirom]

@chibatching Thanks🙏

[chibatching]

I fixed at #662 🙏