Simplify argument of Kotpref.asFlowable extension function

DroidKaigi / conference-app-2018

The Official Conference App for DroidKaigi 2018 Tokyo

Apache License 2.0

1.35k stars 333 forks source link

Closed chibatching closed 6 years ago

chibatching commented 6 years ago

This PR is just proposal. Because it contains cons almost the same as its pros.
Simplify Kotpref.asFlowable function's argument by using PreferenceKey interface introduced from Kotpref 2.4.0
- Pros
- We can use asFlowable with very simple I/F, its parameter is only need property.
- Cons
  - This uses reflection, we have to import kotlin-reflect package.

Before	After

takahirom commented 6 years ago

:eyes:

takahirom commented 6 years ago

It is big 0.9 MB.. kotlin-reflect 🤔 I don't know it is good to use reflect.lite. How about this? https://github.com/Kotlin/kotlinx.reflect.lite

chibatching commented 6 years ago

I didn't know reflect.lite! 😱 I'll try it!! 👍

chibatching commented 6 years ago

It is difficult to accomplish my goal with kotlin-reflect. So, I close this PR. Thank you!