Closed takahirom closed 5 years ago
I try this! ✋
@kiuchikeisuke Sorry, I missed your message 🙇 Assigned 👍
@takahirom I have a question!
Now, search list view only shows Speaker (not shows sessions).Is this the correct specification? 🤔 When I look SearchFragment.kt, search list is assumed to show sessions.
class SearchFragment : DaggerFragment() {
~~
override fun onActivityCreated(savedInstanceState: Bundle?) {
~~
items += result.sessions
.map<Session, Item<*>> { session ->
when (session) {
is Session.SpeechSession ->
speechSessionItemFactory.create(
session,
SearchFragmentDirections.actionSearchToSessionDetail(
session.id
),
false
)
is Session.ServiceSession ->
ServiceSessionItem(session)
}
}
}
}
@kiuchikeisuke Thank you for the question 🙏 I talk to Designer.And you can check the design. Can you tackle this?
https://gallery.io/projects/MCHbtQVoQ2HCZd9Pbpex4PVP/files/MCHtA7U1iMGr6-ZF5RXVf1KRWr8VHz3wbOk (Please send request)
@takahirom Thank you for answering!
And you can check the design.
I send request for gallery.io!
Can you tackle this?
Umm... I think the task of adding sessions will be separated from this issue. 🤔 Because it will defferent from this issue's purpose and I want keep issue simply! 😄 .
So, I would like to organize Issue as follows.
Sorry I miss your comment 🙇
Overview (Required)
Links
You can use 2018 decoration https://github.com/DroidKaigi/conference-app-2018/blob/master/app/src/main/java/io/github/droidkaigi/confsched2018/presentation/common/itemdecoration/StickyHeaderItemDecoration.kt