search

DroidKaigi / conference-app-2019

The Official Conference App for DroidKaigi 2019 Tokyo
https://droidkaigi.jp/2019/en/
Apache License 2.0
816 stars 267 forks source link

Implement :data:db for iOS instead of :data:db-room #348

Open kikuchy opened 5 years ago

kikuchy commented 5 years ago

Overview (Required)

Links

takahirom commented 5 years ago

Sorry, I think :data:db is now interface module. Is that :data:db-impl ?

kikuchy commented 5 years ago

Sorry for my misleading.

Currently :data:db-room is Android implementation module of :data:db.
We need iOS implementation module of :data:db.

Of cource, renaming :data:db-room to :data:db-impl and including both Android/iOS implementation in :data:db-impl is good way.
(But I think it’s little hard. I tried to make :data:db-room Kotlin Multiplatform module, and it broke building :frontend. I can’t investigate why it cause yet. :cry: So I think making each implementation modules individually is good.)

takahirom commented 5 years ago

I have a question 🙋‍♂️ How we debug iOS implementation for development?

kikuchy commented 5 years ago

Debugging means testing?
I never tried testing iOS library written in Kotlin, but maybe this ( https://github.com/JetBrains/kotlin-mpp-example/pull/1 ) will help us.

If you mean "running app in DEBUG mode and stopping at breakpoint", we should make Xcode project of app ( maybe on frontend/ios ?) first.

takahirom commented 5 years ago

I think that it will be easier to contribute if we can create an empty frontend / ios project. What do you think?

kikuchy commented 5 years ago

Good idea!
And making the direction of implementation of iOS app is more better.
What do you think about below?

takahirom commented 5 years ago

Sorry, I don't have an idea. But I think we can implement All VC is in frontend/ios. Because that is Swift source code. I think Only Data modules are written in Kotlin for iOS. What do you think? 👀

nukka123 commented 5 years ago

Perhaps, it might be useful? https://github.com/square/sqldelight

takahirom commented 5 years ago

If we migrate that, Yes. It becomes 1.0. We can consider that 👍

kikuchy commented 5 years ago

I think Only Data modules are written in Kotlin for iOS.

Ok. I think it’s simple and understandable.
We need the template of Xcode project on this direction, and the issue to make that Xcode project... 🙄 I’ll open issue this weekend if I can...

kikuchy commented 5 years ago

Opened https://github.com/DroidKaigi/conference-app-2019/issues/389 🎉