DroidKaigi / conference-app-2019

The Official Conference App for DroidKaigi 2019 Tokyo
https://droidkaigi.jp/2019/en/
Apache License 2.0
815 stars 267 forks source link

Use WorkManager for FCM topic subscription #516

Closed takahirom closed 5 years ago

takahirom commented 5 years ago

Kind (Required)

kirimin commented 5 years ago

If this taks is not in a hurry so much, I want to try to this task. ✋ Can I take this?

takahirom commented 5 years ago

Of course! Thanks! 👍

panpanini commented 5 years ago

@kirimin How's your progress on this~? Is there something we can help you with? 🕵️‍♀️

kirimin commented 5 years ago

@panpanini I'm so sorry for this. 🙏 I don't begin this task yet because of my business work and personal illness... I think I should release this task to other contributors for don't late to the conference. 😢

panpanini commented 5 years ago

Oh that's unfortunate... I hope you feel better soon! I'll unassign you for now then

geckour commented 5 years ago

Can I try this ? 🙋

takahirom commented 5 years ago

Thank you for challenging this issue!

geckour commented 5 years ago

Should Worker show any notification to indicate working as same as IntentService? I guess notifications are used to start foreground service and these will not be necessary.

jmatsu commented 5 years ago

@geckour Good question. No need to keep the current notifications because those notifications were shown due to foreground service matter but not by design.

geckour commented 5 years ago

@jmatsu Thanks, I got it!

geckour commented 5 years ago

I have one more question... If Worker uses Exponential Backoff, does it still needs limitation of retry times (currently set max to 3)?

jmatsu commented 5 years ago

I guess that's also needless. The previous 3 was just an experimental value. 👍

geckour commented 5 years ago

@jmatsu Thanks!