search

DroidKaigi / conference-app-2019

The Official Conference App for DroidKaigi 2019 Tokyo
https://droidkaigi.jp/2019/en/
Apache License 2.0
816 stars 267 forks source link

Occurs IllegalArgumentException in floor map / フロアーマップでIllegalArgumentExceptionが発生する #523

Closed Luecy1 closed 5 years ago

Luecy1 commented 5 years ago

Overview (Required)

Steps To Reproduce

  1. English

    1. Go to floor map
    2. Repeat pinch in and pinch out.
    3. Occurs IllegalArgumentException

  2. Japanese

    1. フロアーマップを開きます
    2. ピンチイン・ピンチアウトの操作を繰り返します
    3. IllegalArgumentExceptionが発生します。

Expected behavior Do not occurs IllegalArgumentException. IllegalArgumentExceptionが発生しないこと

Screenshots If applicable screenshot_20190118-232435

Env:

Additional context It seems PhotoView's known bug. We need to catch IllegalArgumentException.

PhotoViewの既知のバグのようです。 サンプルのようにIllegalArgumentExceptionをキャッチする必要がありそうです。

https://github.com/chrisbanes/PhotoView#issues-with-viewgroups

takahirom commented 5 years ago

Thanks!

ymnder commented 5 years ago

I want to fix it 🙆

tomoya0x00 commented 5 years ago

Thanks! Assigned 👍