search

DroidKaigi / conference-app-2019

The Official Conference App for DroidKaigi 2019 Tokyo
https://droidkaigi.jp/2019/en/
Apache License 2.0
816 stars 267 forks source link

Fix announcement deep linking not working when the app task is alive #790

Closed sugoi-wada closed 5 years ago

sugoi-wada commented 5 years ago

Issue

Overview (Required)

Links

-

Screenshot

jmatsu-bot commented 5 years ago

Try it via https://deploygate.com/distributions/5a3a16ecdd6cd363a242e99f29c9746035b578cf

jmatsu commented 5 years ago

👀 let me have a sec to start code review.

jmatsu-bot commented 5 years ago

Apk comparision results

Property Summary
New File Size 8455216 Bytes. (8.06 MB)
File Size Change +73 Bytes. (+0.07 KB)
Download Size Change +627 Bytes. (+0.61 KB)
New Method Reference Count 62658
Method Reference Count Change 1
New Number of dex file(s) 1
Number of dex file(s) Change 0

Generated by :no_entry_sign: Danger

jmatsu-bot commented 5 years ago

Asserted successfully. :100:

Generated by :no_entry_sign: Danger

jmatsu commented 5 years ago

The CI failed but it was due to memory shortage. So let me merge.