The display position of ripple of Hamburger button is misaligned

DroidKaigi / conference-app-2019

The Official Conference App for DroidKaigi 2019 Tokyo

https://droidkaigi.jp/2019/en/

Apache License 2.0

815 stars 267 forks source link

Open matsudamper opened 5 years ago

matsudamper commented 5 years ago

Overview (Required)

Steps To Reproduce

Expected behavior Do not display ripple or shift ripple to the left.

Screenshots screenshot_20190206-221152

Example shifted to the left
screenshot_20190207-020930

Env:

Additional context

takahirom commented 5 years ago

Thanks for reporting 👍

matsudamper commented 5 years ago

I will do it.🙌 However, I do not know whether to shift Ripple to the left or hide. I think that it is better not to have ripple.

takahirom commented 5 years ago

@matsudamper Do you have any idea for that?

matsudamper commented 5 years ago

I think that It is better to delete ripple. Because there is no ripple in the Play Store etc. I think that it is better than misaligned.