Memory leaks in SessionDetailFragment onwards

[surajsau]

Overview: When session details screen is opened, frequent memory leaks are captured by LeakCanary

Steps To Reproduce: launch app click on any session scroll up and down or click on feedback and scroll between the views Leak Canary records memory leaks very frequently.

Expected behavior: Memory leaks must be reduced

Env:

Device: [e.g. Pixel3] OS: [e.g. 9.0] App Version or the branch [master]

Additional context: It's happening because of ViewDataBinding. It isn't being cleared in onDestroyView() We can take out binding as variable in the base DaggerFragment and set it to null in onDestroyView()

[surajsau]

@takahirom I can take it up and fix it if needed.

[takahirom]

Thank you! But, now we are working for DroidKaigi/conference-app-2020. This repository is conference-app-2019 If you don't care, please take a look at the 2020 repositories 🙏 https://github.com/DroidKaigi/conference-app-2020

[surajsau]

あ! 間違いました！ごめんなさい！笑笑