DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
774 stars 327 forks source link

defines the default animation #245

Open rmakiyama opened 4 years ago

rmakiyama commented 4 years ago

Kind (Required)

https://github.com/DroidKaigi/conference-app-2020/blob/master/corecomponent/androidcomponent/src/main/res/navigation/navigation.xml#L14

ochim commented 4 years ago

I want to contribute. But I don't understand the aim of this issue. modify @anim/fade_in and @anim/fade_out ? add new animation files ?

takahirom commented 4 years ago

Thank you for the comment! 👍 We should implement the XML attribute for all actions. But we don't want to create boilerplate.

app:enterAnim="@anim/fade_in"
            app:exitAnim="@anim/fade_out"
            app:popEnterAnim="@anim/fade_in"
            app:popExitAnim="@anim/fade_out"

https://github.com/DroidKaigi/conference-app-2020/blob/master/corecomponent/androidcomponent/src/main/res/navigation/navigation.xml#L14

So we want to add default animation.

ochim commented 4 years ago

OK, I see. The boilerplate is wordy. But I can't find the solution. Sorry

takahirom commented 4 years ago

It's ok. me too 😄

umakoz commented 4 years ago

I wanna try. 🙋‍♂️

takahirom commented 4 years ago

Thanks! Assigned