search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
774 stars 327 forks source link

Add material animation(transition) #592

Closed koji-1009 closed 4 years ago

koji-1009 commented 4 years ago

Issue

Overview (Required)

Links

Screenshot

Type Before After
Stagger(contributor)
Stagger(staff)
FadeThrough(SessionDetail)
takahirom commented 4 years ago

LGTM 👍 Can you fix the conflict? 🙇

koji-1009 commented 4 years ago

Thanks! Of course 😊

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/061b83425a3fba57dd243d7c63686e0ef0d8439c. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago
2 Warnings
:warning: feature/session/src/main/res/layout/item_session.xml#L63 - Missing contentDescription attribute on image
:warning: feature/session/src/main/res/layout/item_speaker_session.xml#L69 - Missing contentDescription attribute on image

No error was reported but at least one warning was found.

Generated by :no_entry_sign: Danger

koji-1009 commented 4 years ago

@takahirom Hi, I resolved conflict! 5fdfcae

takahirom commented 4 years ago

Thank you for the awesome animations!