Expand ripple effect for speaker

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo

https://droidkaigi.jp/2020/en/

Apache License 2.0

774 stars 327 forks source link

Closed phicdy closed 4 years ago

phicdy commented 4 years ago

Nothing

We can tap all of the line of speaker in session detail, but ripple effect is only for speaker icon and name

Nothing

Before	After

takahirom commented 4 years ago

LGTM 👍

jmatsu-bot commented 4 years ago

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

	1 Warning
:warning:	feature/session/src/main/res/layout/item_session_detail_speaker.xml#L25 - Missing `contentDescription` attribute on image

No error was reported but at least one warning was found.

Generated by :no_entry_sign: Danger