search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
774 stars 327 forks source link

Add notification for favorited sessions #607

Closed eyedol closed 4 years ago

eyedol commented 4 years ago

Issue

Overview (Required)

Links

eyedol commented 4 years ago

An early review would be appreciated 🙏

takahirom commented 4 years ago

đź‘€

eyedol commented 4 years ago

@takahirom thanks for the earlier review. I'm ready for the final review and a possible merge 🙇

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/6bd6ac63e80bbb0d406ab92b0a575f9cc125b65e. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago
2 Warnings
:warning: corecomponent/androidcomponent/src/main/res/values-ja/strings.xml#L6 - The resource string “material_label” has been marked as translatable=”false” elsewhere (usually in the values folder), but is translated to “ja” (Japanese) here
:warning: corecomponent/androidcomponent/src/main/res/values-ja/strings.xml#L16 - The resource string “speaker_label” has been marked as translatable=”false” elsewhere (usually in the values folder), but is translated to “ja” (Japanese) here

No error was reported but at least one warning was found.

Generated by :no_entry_sign: Danger