search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
774 stars 327 forks source link

Fix SessionPage parcelize crash #612

Closed myoshita closed 4 years ago

myoshita commented 4 years ago

Issue

Overview (Required)

Env:

Links

-

Screenshot

Before After
takahirom commented 4 years ago

Can you try remove @Parcelize from sealed class and mark @AndroidParcelize in a subclass? https://qiita.com/takahirom/items/5f3d405c854b6015823a

myoshita commented 4 years ago

I appreciate for reviewing my code and showing the solution of Parcelize. Fixed that 🙇

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/a011d682755fad9d0eb3178263387d4484f549b9. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger

takahirom commented 4 years ago

Thank you! LGTM!🙏