Add retry on Contributors screen - Githubissues

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo

https://droidkaigi.jp/2020/en/

Apache License 2.0

774 stars 327 forks source link

Add retry on Contributors screen #616

Closed mkano9 closed 4 years ago

mkano9 commented 4 years ago

Issue

No Issue filed
Follow-up from #115

Overview (Required)

Allow the user to retry reloading the data when the API call fails.

Before:

Problem 1: When no cache exists and the API call fails, there's no way to reload the Contributors screen unless you exit and re-enter the Contributors screen.
Problem 2: The loading indicator gets dismissed as soon as the repository loads data from DB regardless of whether cache exists or not. The app then starts an API call which could make the user wait for some time on a blank screen without any loading indicator until the API call completes.

After:

When the API call fails, if there's no cache to show any data, then show a retry button. If cache exists, then show the retry option on the snackbar while displaying the current data.
Loading indicator continues to be displayed until either real data is retrieved or an error occurs.

Screenshot

Note:

Airplane mode is enabled in the beginning of the videos to simulate network errors.
Added a delay of 3s to the API calls to simulate slow network connection.

Before	After

Error when contributors cache exists:

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/ffc3ed914aad93be092a004d41fa9d450ede3cf1. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger

takahirom commented 4 years ago

👀

mkano9 commented 4 years ago

@takahirom Thank you again for the review!