DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
774 stars 327 forks source link

Add ripple effect to Read more button in the SessionDetailFragment #617

Closed tfandkusu closed 4 years ago

tfandkusu commented 4 years ago

Issue

none

Overview (Required)

Links

Current implementation uses ClickableSpan, but it has no solution to add ripple effect.

So, New TextView of Read more is added and its coordinates are calculated by omitted description text's character coordinates.

Screenshot

Before After
jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/e3bfaefc2b011d3d10cb5f24f2cf1c59675319cc. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger

takahirom commented 4 years ago

Sorry I will look this 🙇

tfandkusu commented 4 years ago

I withdraw this PR because current implementation which clickable range is all of description text has no accessibility problem.