search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
774 stars 327 forks source link

move unit test to test folder #622

Closed a25max closed 4 years ago

a25max commented 4 years ago

Issue

Overview (Required)

Links

No

Screenshot

No

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/5ea9658a5704d8287ac9ee5239256d2f1d6bd9dc. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago
2 Errors
:no_entry_sign: Tests have failed, see below for more information.
:no_entry_sign: At least one test case failed

Tests:

Name Classname Time
isPass_forSpeechSession[empty filter passes beginners session] io.github.droidkaigi.confsched2020.model.FiltersTest$WhenSpeechSessionIsChecked 0.004
isPass_forSpeechSession[empty filter passes non beginners session] io.github.droidkaigi.confsched2020.model.FiltersTest$WhenSpeechSessionIsChecked 0.001
isPass_forSpeechSession[Beginners filter passes beginners session] io.github.droidkaigi.confsched2020.model.FiltersTest$WhenSpeechSessionIsChecked 0.001
isPass_forSpeechSession[Beginners filter does not pass non beginners session] io.github.droidkaigi.confsched2020.model.FiltersTest$WhenSpeechSessionIsChecked 0.0
isPass_forSpeechSession[Unspecified filter does not pass beginners session] io.github.droidkaigi.confsched2020.model.FiltersTest$WhenSpeechSessionIsChecked 0.0
isPass_forSpeechSession[Unspecified filter passes non beginners session] io.github.droidkaigi.confsched2020.model.FiltersTest$WhenSpeechSessionIsChecked 0.0
isPass_forSpeechSession[filter has Beginners and Unspecified passes beginners session] io.github.droidkaigi.confsched2020.model.FiltersTest$WhenSpeechSessionIsChecked 0.001
isPass_forSpeechSession[filter has Beginners and Unspecified passes non beginners session] io.github.droidkaigi.confsched2020.model.FiltersTest$WhenSpeechSessionIsChecked 0.0

Generated by :no_entry_sign: Danger

takahirom commented 4 years ago

Does that tests failed? 👀

a25max commented 4 years ago

Yes, I can't understand this test so I may resolve this test more time.

a25max commented 4 years ago

I think I should mod Filters class. add about audienceCategories.

a25max commented 4 years ago

Sorry, give up 😭

roana0229 commented 4 years ago

No worries. 😄 Thank you for your challenge 👍 Could you please close this PR ?

a25max commented 4 years ago

OK, I see. Thank you 🙏