search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
774 stars 327 forks source link

iOS App floor map #624

Closed entaku0818 closed 4 years ago

entaku0818 commented 4 years ago

Issue

Overview (Required)

Links

-

Screenshot

Before After
nil
nil
entaku0818 commented 4 years ago

@ry-itto I think fix all issue!

ry-itto commented 4 years ago

@entaku19890818 Thanks! But it looks still conflicting... Please fix it?

After fixing it, I will review this πŸ˜„

entaku0818 commented 4 years ago

Fixed it!

ry-itto commented 4 years ago

I think this is not fitting the design... For example, bar color.

current design
γ‚Ήγ‚―γƒͺγƒΌγƒ³γ‚·γƒ§γƒƒγƒˆ 2020-01-31 16 29 45
entaku0818 commented 4 years ago

Sorry.... I will change bar color when leave to my home. Are you pointing out that the size of the map is different?

ry-itto commented 4 years ago

Are you pointing out that the size of the map is different?

No, I don't care that. πŸ˜„

Please add view's title and change color πŸ™

entaku0818 commented 4 years ago

@ry-itto After merging the master again and make init I got the following error messages.πŸ˜“ Do you know the cause?

MacBook-Pro-2:ios-base endo$ make init
mkdir -p /Users/endo/conference-app-2020/ios-base/DroidKaigi\ 2020/Generated
mint run swiftgen swiftgen
🌱  Using SwiftGen/SwiftGen 6.1.0 from Mintfile.
🌱  Cloning SwiftGen 6.1.0
🌱  Resolving package
🌱  Building package
[1/10] Compiling writer.c
[2/10] Compiling reader.c
[3/10] Compiling parser.c
[4/10] Compiling api.c
[5/10] Compiling emitter.c
[6/10] Compiling scanner.c
[7/11] Compiling Kanna CSS.swift
/private/var/folders/tc/7k760n257395s_tvy3xdhm1m0000gq/T/mint/github.com_SwiftGen_SwiftGen/.build/checkouts/Kanna/Modules/libxml2-kanna.h:1:9: note: while building module 'libxml2' imported from /private/var/folders/tc/7k760n257395s_tvy3xdhm1m0000gq/T/mint/github.com_SwiftGen_SwiftGen/.build/checkouts/Kanna/Modules/libxml2-kanna.h:1:
#import <libxml2/libxml/HTMLtree.h>
        ^
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "libxml/HTMLparser.h"
        ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/libxml2/libxml/HTMLparser.h:15:10: error: 'libxml/xmlversion.h' file not found
#include <libxml/xmlversion.h>
         ^
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "libxml2-kanna.h"
        ^
/private/var/folders/tc/7k760n257395s_tvy3xdhm1m0000gq/T/mint/github.com_SwiftGen_SwiftGen/.build/checkouts/Kanna/Modules/libxml2-kanna.h:1:9: error: could not build module 'libxml2'
#import <libxml2/libxml/HTMLtree.h>
        ^
/private/var/folders/tc/7k760n257395s_tvy3xdhm1m0000gq/T/mint/github.com_SwiftGen_SwiftGen/.build/checkouts/Kanna/Sources/Kanna/CSS.swift:27:8: error: could not build Objective-C module 'libxmlKanna'
import libxmlKanna
       ^
'SwiftClibxml2' /private/var/folders/tc/7k760n257395s_tvy3xdhm1m0000gq/T/mint/github.com_SwiftGen_SwiftGen/.build/checkouts/SwiftClibxml2: warning: system packages are deprecated; use system library targets instead
🌱  Encountered error during "swift build -c release -Xswiftc -target -Xswiftc x86_64-apple-macosx10.15". Use --verbose to see full output
🌱  Failed to build SwiftGen 6.1.0 with SPM
make: *** [swiftgen] Error 1
entaku0818 commented 4 years ago

https://github.com/DroidKaigi/conference-app-2020/issues/667

ry-itto commented 4 years ago

Oh sorry.. Please install libxml2 by brew πŸ™

entaku0818 commented 4 years ago

thanks!

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/850be1894acb8da40f508a3702a77bce766d10d2. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger