search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
774 stars 327 forks source link

Change specific chip's color in session detail screen #627

Closed ttanaka330 closed 4 years ago

ttanaka330 commented 4 years ago

Issue

Overview (Required)

Links

-

Screenshot

Before After
takahirom commented 4 years ago

Thanks! Is it ok when dark theme?? 🌚

takahirom commented 4 years ago

We can create XML like this 👀 https://github.com/DroidKaigi/conference-app-2020/blob/master/feature/session/src/main/res/color-night/search_icon.xml

ttanaka330 commented 4 years ago

Thanks for the hint!

I forget the dark theme. Is there a color specification for the dark theme? Does category match colorOnSurface?

takahirom commented 4 years ago

No specifications. You can choose for your senses. 😄

ttanaka330 commented 4 years ago

For dark theme colors, set colors that have changed saturation from light theme. The colors of the light theme have also changed to match Figma.

takahirom commented 4 years ago

Looks Great!! Thanks!

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/ca13e5f6c939178ef8404a67be7038233c1f8e83. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger

ttanaka330 commented 4 years ago

Thanks for the review. By the way, branches don't merge, what do I do?

takahirom commented 4 years ago

Thanks I just forgot it 🙇🙇