search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
774 stars 327 forks source link

[iOS] Implement announcements #628

Closed yuta24 closed 4 years ago

yuta24 commented 4 years ago

Issue

Overview (Required)

Links

Screenshot

Before After(EN) After(JA)
yuta24 commented 4 years ago

@ry-itto

iconImage's background color and tint color

What color should be specified for the background and tint of the icon image? please tell me 🙏 I can't find spec in Figma.

ry-itto commented 4 years ago

@yuta24 For example, this one. https://www.figma.com/file/4r9becvhDy3GfXaXex8E8d/App?node-id=22%3A302

Please create color asset named Secondary300 with hex #00B5E2. This is for tintColor. And named Secondary50 with hex #DCF3FA. 🙏

ry-itto commented 4 years ago

@takahirom Is this OK? I found an issue. I think this is server side issue. In Japanese, contents are garbled.

takahirom commented 4 years ago

https://deploy-preview-49--droidkaigi-api-dev.netlify.com/2020/announcements/ja/index.json 👀

takahirom commented 4 years ago

image 👀

takahirom commented 4 years ago

Perhaps this PR is trying to treat UTF-8 strings as Unicode.

takahirom commented 4 years ago

It could be a Ktor Client issue, or it could be an iOS implementation. 👀

takahirom commented 4 years ago

Can you try this? https://github.com/DroidKaigi/conference-app-2020/commit/28d4c661e4dd4264668300f7f39f83c223a8c883

ry-itto commented 4 years ago

@takahirom ~It doesn't work ... https://github.com/DroidKaigi/conference-app-2020/commit/28d4c661e4dd4264668300f7f39f83c223a8c883~ It seems like iOS issue 🙏 Thanks for suggesting.

yuta24 commented 4 years ago

@ry-itto CC @takahirom

I fixed icon color in Announcment screen. And, I fixed garbled in Japanease. please review.

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/6b556c0adcd9e10df25279b4af6ccf1f6fc7a4f7. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger