DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
774 stars 327 forks source link

[iOS] Enable file_header rule to ban header comments #635

Closed woxtu closed 4 years ago

woxtu commented 4 years ago

Issue

Overview (Required)

Links

ry-itto commented 4 years ago

Thanks! This is nice 😄

But I find SwiftLint doesn't work for untracked files. Please fix with this? I think we should fix scripts/lint.sh. 🙏

woxtu commented 4 years ago

True. Let me think about it.

ry-itto commented 4 years ago

🙏

ry-itto commented 4 years ago

@woxtu

git status --porcelain | awk -F'"' '{print $2}' | grep -e '\(.*\).swift$'

This script is useful to fulfill above. 😄

woxtu commented 4 years ago

@ry-itto This is it! I didn't know --porcelain.

This is my answer:

git status --porcelain | grep -e '^[ ?][^D] ".*\.swift"$' | awk -F'"' '{print $2}'
jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/9253d12f0fcaa1ba2ce07c9b579e671acfbdd8b9. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

ry-itto commented 4 years ago

Oh, thanks to fix both of lint.sh and format.sh 😄

LGTM 👍

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger