search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
774 stars 327 forks source link

Add pin for floormap fragment #637

Closed Veget-ables closed 4 years ago

Veget-ables commented 4 years ago

Issue

Overview (Required)

When you open a floor map from a session, a pinned map image is displayed according to the floor of the session.

TODO：Since the displayed images are dummy, it needs to be replaced with appropriate images.

Screenshot

Before:
Only unmarked map was displayed.

After :

・If you open a floor map from session page, the pinned map image is displayed according to the floor of the session. Currently displayed images are dummy.

スクリーンショット 2020-01-27 22 35 58

・If you open a floor map from Navigation Drawer, the unmarked map is displayed.

スクリーンショット 2020-01-27 22 36 10
takahirom commented 4 years ago

👀

takahirom commented 4 years ago

👀

jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/320e859fc4ef992c48dcfc3c4444618dee33fd44. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger

takahirom commented 4 years ago

Thanks! LGTM 👍