Use ContentLoadingProgressBar instead of ProgressBar

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo

https://droidkaigi.jp/2020/en/

Apache License 2.0

775 stars 327 forks source link

Closed rmakiyama closed 4 years ago

rmakiyama commented 4 years ago

Use ContentLoadingProgressBar instead of ProgressBar
- I left the ProgressTimeLatch for other view
I think, progress shows in no time without setting gone visibility in xml as default.
- (not using min show time because not call show() method.)
- Is this right behavior?（or case by case?）
- ex) show progress in about screen without delay 500ms.

Before	After

takahirom commented 4 years ago

👀

rmakiyama commented 4 years ago

I think this method name is not really good.... do you have any idea? 🙇

takahirom commented 4 years ago

How about isShow? var ContentLoadingProgressBar.isShow

jmatsu-bot commented 4 years ago

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

	1 Warning
:warning:	feature/about/src/main/res/layout/fragment_about.xml#L33 - Hardcoded string “go to staff”, should use `@string` resource

No error was reported but at least one warning was found.

Generated by :no_entry_sign: Danger

takahirom commented 4 years ago

LGTM 👍 🔄