search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
775 stars 327 forks source link

iOS Add "Event" to tab #657

Closed ry-itto closed 4 years ago

ry-itto commented 4 years ago

Kind (Required)

clockvoid commented 4 years ago

Yesterday, I tried it and I did it.

Like this ->

However, I'm so nervous because I'm a beginner to develop iOS apps. Do you face me if I submit a PR? Also, is this issue contains to add event content?

ry-itto commented 4 years ago

@clockvoid Thanks 😄 It is ok to implement adding tab only. 👍 If you create a PR, we will check it.

clockvoid commented 4 years ago

@ry-itto I created a new PR #708 to fix an issue due to my misunderstanding. Please check it. I'm sorry to compound the problem. 🙇