search

DroidKaigi / conference-app-2020

The Official Conference App for DroidKaigi 2020 Tokyo
https://droidkaigi.jp/2020/en/
Apache License 2.0
775 stars 327 forks source link

[iOS] Implement about DroidKaigi view #672

Closed myihsan closed 4 years ago

myihsan commented 4 years ago

Issue

Overview (Required)

Screenshot

Before After
myihsan commented 4 years ago

@ry-itto

Thanks! Please fix some points and pass CI tasks 🙏

It looks like something went wrong about Danger that is not related to this pull request. What should I do about it?

takahirom commented 4 years ago

Can you merge from master for fixing CI? 🙏

myihsan commented 4 years ago

@takahirom Not working, did I do something wrong?

takahirom commented 4 years ago

👀 🤔 https://github.com/ruby-git/ruby-git/blob/v1.5.0/lib/git/diff.rb#L152

bundler: failed to load command: danger (/home/circleci/conference-app-2020/.ci/vendor/bundle/ruby/2.6.0/bin/danger)
Danger::DSLError: 
[!] Invalid `static_analysis.Dangerfile` file: undefined method `[]' for nil:NilClass
 #  from .ci/danger/static_analysis.Dangerfile:19
 #  -------------------------------------------
 #      plugin.report_file = xml
 >      plugin.lint(inline_mode: true)
 #    end
 #  -------------------------------------------

  /home/circleci/conference-app-2020/.ci/vendor/bundle/ruby/2.6.0/gems/git-1.5.0/lib/git/diff.rb:152:in `block in process_full_diff'
  /home/circleci/conference-app-2020/.ci/vendor/bundle/ruby/2.6.0/gems/git-1.5.0/lib/git/diff.rb:135:in `each'
  /home/circleci/conference-app-2020/.ci/vendor/bundle/ruby/2.6.0/gems/git-1.5.0/lib/git/diff.rb:135:in `process_full_diff'
  /home/circleci/conference-app-2020/.ci/vendor/bundle/ruby/2.6.0/gems/git-1.5.0/lib/git/diff.rb:109:in `process_full'
  /home/circleci/conference-app-2020/.ci/vendor/bundle/ruby/2.6.0/gems/git-1.5.0/lib/git/diff.rb:68:in `each'
  /home/circleci/conference-app-2020/.ci/vendor/bundle/ruby/2.6.0/gems/danger-6.2.0/lib/danger/danger_core/plugins/dangerfile_git_plugin.rb:75:in `select'
  /home/circleci/conference-app-2020/.ci/vendor/bundle/ruby/2.6.0/gems/danger-6.2.0/lib/danger/danger_core/plugins/dangerfile_git_plugin.rb:75:in `modified_files'
  /home/circleci/conference-app-2020/.ci/vendor/bundle/ruby/2.6.0/gems/danger-android_lint-0.0.8/lib/android_lint/plugin.rb:190:in `send_inline_comment'
jmatsu-bot commented 4 years ago

Your apk has been deployed to https://deploygate.com/distributions/7cfc242bc68bac46c5d1ae5012e7a98e9d77d5c1. Anyone can try your changes via the link.

Generated by :no_entry_sign: Danger

jmatsu-bot commented 4 years ago

No issue was reported. Cool!

Generated by :no_entry_sign: Danger

myihsan commented 4 years ago

@takahirom It turns out there was a special character that cannot be notified on my Mac, and I have no idea why it existed. Thank you for your support!🙏

The related PR is here.